-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model control plane technical documentation #2111
Conversation
…-control-plane-docs
…-control-plane-docs
…-control-plane-docs
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 27.3%, saving 51.53 KB.
221 images did not require optimisation. |
…nml-io/zenml into doc/OSS-2465-model-control-plane-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't go through all the lines, just making a checkpoint before our planning meeting.
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/advanced-guide/artifact-management/model-management.md
Outdated
Show resolved
Hide resolved
…management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
…management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
…management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
…management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
…management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
…management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
…management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
WalkthroughWalkthroughZenML documentation has been updated to include new sections on model management. Hyperlinks in the core concepts have been corrected, and a comprehensive explanation of model handling in ZenML, including API and cloud dashboard interactions, has been added. The table of contents and advanced guide reflect these updates by introducing model management entries, and a new detailed guide on model management is now available. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
…nml-io/zenml into doc/OSS-2465-model-control-plane-docs
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (4)
- docs/book/getting-started/core-concepts.md (2 hunks)
- docs/book/toc.md (1 hunks)
- docs/book/user-guide/advanced-guide/advanced-guide.md (1 hunks)
- docs/book/user-guide/advanced-guide/artifact-management/model-management.md (1 hunks)
Files skipped from review due to trivial changes (2)
- docs/book/getting-started/core-concepts.md
- docs/book/toc.md
Additional comments: 7
docs/book/user-guide/advanced-guide/advanced-guide.md (1)
- 9-9: The addition of "Model management" to the table is consistent with the PR objectives and enhances the guide by including this important topic. Ensure that the hyperlink to
model-management.md
is functional and leads to the correct documentation section.docs/book/user-guide/advanced-guide/artifact-management/model-management.md (6)
1-12: The introduction to model management clearly defines the scope and importance of models within ZenML. It's well-written and provides a good starting point for understanding the concept.
24-32: The section on Model Versions is informative and aligns with the overall documentation structure. Verify that the hyperlinks, such as the one to the ZenML Cloud dashboard, are accurate and lead to the intended pages.
34-55: The instructions for registering models using the CLI are clear. Confirm that the command
zenml model register
and its options are correctly documented and match the actual CLI functionality.79-89: The section on implicit registration by ZenML is well-explained. The code example provided should be verified for correctness and practicality within the context of a ZenML pipeline.
267-311: The section on linking artifacts to models is crucial and appears to be well-documented. Verify that the code examples and configurations mentioned are accurate and align with the current capabilities of ZenML.
325-325: Confirm that the image linked at the end of the document is displayed correctly and does not raise any privacy concerns, as it includes a tracking pixel (
x-pxid
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks!
* Make logging output consistent * fix links * add models section to core concepts * update TOC * update advanced guide links * add model management page * add dashboard page * add image of cloud dashboard * add using models page * add extra text * update TOC * add model registration docs * update dashboard docs * add scarf * update with versions and stages * handling promotion * add final model management section * update TOC * delete extra section * fix line break * Optimised images with calibre/image-actions * move mcp doc page to artifact management * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Refactor model management documentation * Update autonumbering of model versions section in model management * Update model linkage configuration in model-management.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> (cherry picked from commit 898e030)
* Make logging output consistent * fix links * add models section to core concepts * update TOC * update advanced guide links * add model management page * add dashboard page * add image of cloud dashboard * add using models page * add extra text * update TOC * add model registration docs * update dashboard docs * add scarf * update with versions and stages * handling promotion * add final model management section * update TOC * delete extra section * fix line break * Optimised images with calibre/image-actions * move mcp doc page to artifact management * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Update docs/book/user-guide/advanced-guide/artifact-management/model-management.md Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> * Refactor model management documentation * Update autonumbering of model versions section in model management * Update model linkage configuration in model-management.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com> (cherry picked from commit 898e030)
A first draft of the MCP technical docs. Preview most of the changes here on Gitbook.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit