Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run DB migration testing using MySQL alongside SQLite #2113

Merged
merged 17 commits into from
Dec 19, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Dec 5, 2023

Added mysql to our DB migration test suite (+ updated the script accordingly).

https://github.com/zenml-io/zenml/actions/runs/7117277436?pr=2113 shows tests passing.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added enhancement New feature or request internal To filter out internal PRs and issues labels Dec 5, 2023
@strickvl strickvl changed the title Run DB migration testing using MySQL Run DB migration testing using MySQL alongside SQLite Dec 6, 2023
@strickvl strickvl merged commit 9a582f6 into develop Dec 19, 2023
4 of 21 checks passed
@strickvl strickvl deleted the feature/OSS-2678-run-db-migration-testing-on-mysql branch December 19, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants