-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run DB migration testing using MySQL alongside SQLite #2113
Merged
strickvl
merged 17 commits into
develop
from
feature/OSS-2678-run-db-migration-testing-on-mysql
Dec 19, 2023
Merged
Run DB migration testing using MySQL alongside SQLite #2113
strickvl
merged 17 commits into
develop
from
feature/OSS-2678-run-db-migration-testing-on-mysql
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
added
enhancement
New feature or request
internal
To filter out internal PRs and issues
labels
Dec 5, 2023
…un-db-migration-testing-on-mysql
…github.com:zenml-io/zenml into feature/OSS-2678-run-db-migration-testing-on-mysql
strickvl
changed the title
Run DB migration testing using MySQL
Run DB migration testing using MySQL alongside SQLite
Dec 6, 2023
avishniakov
reviewed
Dec 13, 2023
avishniakov
approved these changes
Dec 13, 2023
strickvl
deleted the
feature/OSS-2678-run-db-migration-testing-on-mysql
branch
December 19, 2023 14:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mysql to our DB migration test suite (+ updated the script accordingly).
https://github.com/zenml-io/zenml/actions/runs/7117277436?pr=2113 shows tests passing.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes