Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various bugs #2124

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Fix various bugs #2124

merged 7 commits into from
Dec 12, 2023

Conversation

stefannica
Copy link
Contributor

@stefannica stefannica commented Dec 8, 2023 •
edited
Loading

Describe changes

A collection of bug fixes:

  • Fix the message about missing secrets to not mention secrets-managers
  • Add configurable clock skew tolerance for service connector credential expiry checks
  • fix W&B integration

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Dec 8, 2023
@stefannica stefannica changed the title Fix the message about missing secrets to not mention secrets-managers Fix various bugs Dec 8, 2023
@stefannica stefannica changed the title Fix various bugs [WIP] Fix various bugs Dec 8, 2023
@stefannica stefannica marked this pull request as ready for review December 8, 2023 12:41
@stefannica stefannica force-pushed the bug/fix-various-bugs branch 2 times, most recently from 2394c48 to 0621c03 Compare December 8, 2023 15:05
@github-actions GitHub Actions
Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

@stefannica stefannica changed the title [WIP] Fix various bugs Fix various bugs Dec 12, 2023
@stefannica stefannica mentioned this pull request Dec 12, 2023
Closed
9 tasks
avishniakov
avishniakov approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small clarification.

src/zenml/zen_stores/migrations/versions/e5225281b4d3_add_connector_skew_tolerance.py Show resolved Hide resolved
@stefannica stefannica merged commit 1494162 into develop Dec 12, 2023
23 of 28 checks passed
@stefannica stefannica deleted the bug/fix-various-bugs branch December 12, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexejPenner AlexejPenner AlexejPenner approved these changes

@bcdurak bcdurak bcdurak approved these changes

@safoinme safoinme safoinme approved these changes

@avishniakov avishniakov avishniakov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stefannica @avishniakov @safoinme @bcdurak @AlexejPenner @actions-user