Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesSparkStepOperator imports fails #2159

Merged
merged 6 commits into from
Dec 16, 2023

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Dec 15, 2023

Describe changes

I fixed the importing issue of BuildConfiguration in KubernetesSparkStepOperator to resolve https://zenml.slack.com/archives/C01FWQ5D0TT/p1702628389459069.

│   125 │   │   for step_name, step in deployment.step_configurations.items():                     │
│   126 │   │   │   if step.config.step_operator == self.name:                                     │
│ ❱ 127 │   │   │   │   build = BuildConfiguration(                                                │
│   128 │   │   │   │   │   key=SPARK_DOCKER_IMAGE_KEY,                                            │
│   129 │   │   │   │   │   settings=step.config.docker_settings,                                  │
│   130 │   │   │   │   │   step_name=step_name,                                                   │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
NameError: name 'BuildConfiguration' is not defined

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@avishniakov avishniakov changed the base branch from main to develop December 15, 2023 09:12
@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Dec 15, 2023
Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

Copy link
Contributor

NLP template updates in examples/nlp-case have been pushed.

@avishniakov avishniakov merged commit c0aba01 into develop Dec 16, 2023
4 checks passed
@avishniakov avishniakov deleted the bugfix/KubernetesSparkStepOperator-imports branch December 16, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants