-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update stacks page and add azure 1-click from dashboard docs #3082
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 14.6%, saving 386.45 KB.
315 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. In addition, heres a few other things:
- Previously, we always linked to https://docs.zenml.io/user-guide/production-guide/understand-stacks whenever we wanted to talk about stacks. Can you go through the docs and link to this page instead?
- I think the page you wrote doesn't really have a coherent story IMO. It should be a starting chapter that leads into the "deploy a cloud stack..." etc sections... not sure about this feedback but maybe you can take a step back and think what this section needs as an intro to stacks and this section?
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 10.6%, saving 2.69 KB.
327 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
i think we should still link to that page in the docs because that sort of introduces the stack at a basic level. this new page:
i agree that the first version had headings that felt out of place a bit. but i think content-wise it felt right to me. i have now updated the page (linked above). can you take a look and let me know if it's coherent? my thought was this: the page talks about managing stacks, so it begins with what a stack is and how to view the stack as a way to organize your envs. Then it talks about managing creds for your stacks, and finally how to navigate their deployment -> leading to the deployment pages later |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 5.6%, saving 7.53 KB.
328 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i agree with the two points you laid out @wjayesh so lets move on from those. I left new review comments now
docs/book/how-to/contribute-to-zenml/implement-a-custom-integration.md
Outdated
Show resolved
Hide resolved
…om/zenml-io/zenml into docs/stack-provisioning-strategies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smal nit otherwise approved!
Describe changes
I implemented the docs page for the azure 1-click deployment on the ZenML Dashboard and modified the stacks page.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes