Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split Factory class (#452) #462

Closed
wants to merge 13 commits into from
Closed

feat: split Factory class (#452) #462

wants to merge 13 commits into from

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented May 10, 2023

"meta" PR for the big work about revamping the factories

TODO:

Going further, just here for the record:

  • create some AttributeNormalizer classes, and extract all this logic from factories
  • totally remove everything related to persistence from Configuration
  • create a class \Zenstruck\Foundry\Persistence\ObjectManager

@nikophil nikophil marked this pull request as draft May 10, 2023 16:48
@nikophil nikophil force-pushed the feat/split-factories branch 3 times, most recently from 0b4f36e to 33db307 Compare May 15, 2023 06:38
@nikophil nikophil mentioned this pull request Jun 9, 2023
@nikophil nikophil force-pushed the feat/split-factories branch 3 times, most recently from 33983f0 to 517fec9 Compare August 26, 2023 06:47
@nikophil nikophil closed this Nov 7, 2023
@nikophil nikophil deleted the feat/split-factories branch November 15, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants