-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split Factory class (#452) #462
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
feat/split-factories
branch
3 times, most recently
from
May 15, 2023 06:38
0b4f36e
to
33db307
Compare
nikophil
force-pushed
the
feat/split-factories
branch
from
May 24, 2023 18:42
33db307
to
e708a34
Compare
Merged
nikophil
force-pushed
the
feat/split-factories
branch
from
July 21, 2023 10:22
e708a34
to
7dfd952
Compare
nikophil
force-pushed
the
feat/split-factories
branch
from
August 11, 2023 13:13
cb1b9f7
to
b535afb
Compare
nikophil
force-pushed
the
feat/split-factories
branch
3 times, most recently
from
August 26, 2023 06:47
33983f0
to
517fec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"meta" PR for the big work about revamping the factories
TODO:
CHANGELOG.md
to explain existing@phpstan-method
can be dropped in userland@sca-method
and explain how to install the sca extensionsObjectFactory
in case of not persisted object feat(make:factory): use ObjectFactory for not persisted objects #494make:factory
to remove@phpstan-method``PeristenceObjectFactory
chore: psalm plugin #469Going further, just here for the record:
AttributeNormalizer
classes, and extract all this logic from factoriesConfiguration
\Zenstruck\Foundry\Persistence\ObjectManager