-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include message data in the history #17
Comments
Good idea. I'm trying to think how we'd store this - it needs to be json in the db. Simple as running through It'd be nice to reuse the messenger sererializer system but by default, I believe it uses |
I checked and you're right. If we're going to use the messenger serializer, we'll end up with encoded PHP objects in the DB. I would say it should be safe to use the |
This would be a great feature. @SpartakusMd Are you up for an PR? |
Was thinking to do it, but didn't find the time yet. @Chris53897, if you're willing to do it, feel free. |
I will probably have some time after 01.10 to crate some PRs. I will decide than, wich one i will pick. |
Thinking about this feature some more. If we're going to add it, it'll need to be before 1.0 as it would require a breaking change (the extra entity column). Question for you guys though: is making your message
Could/should this be handled via serializer groups? |
@kbond, my use case would benefit from storing the full message in the history. It gives the possibility to process the data later and still have a human view via \Stringable for the message. In the end, I could live without it, but would be something nice to have. I prepared a sample PR #46 to see if it's a good approach. For implementation, I used What do you think? Should this land in the package? Is it something which wouldn't be required? Should there be something more added? |
I believe, in some cases it would be helpful to also store the data from the message too in the history. In case the message contains sensitive info, we could use another stamp to indicate that for this message the data should not be recorded.
The text was updated successfully, but these errors were encountered: