Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canbus: isotp: Context buffer memory leaks #60707

Closed
gramsay0 opened this issue Jul 21, 2023 · 0 comments · Fixed by #60663
Closed

canbus: isotp: Context buffer memory leaks #60707

gramsay0 opened this issue Jul 21, 2023 · 0 comments · Fixed by #60663
Assignees
@henrikbrixandersen
Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@gramsay0
Copy link
Contributor

When using ISO-TP context buffers (CONFIG_ISOTP_ENABLE_CONTEXT_BUFFERS) the send context (struct isotp_send_ctx) is allocated from a memory slab.

During the send() function if either attach_fc_filter() or send_sf() return an error then the context buffer is not free'd, causing a memory leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikbrixandersen henrikbrixandersen

Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

canbus: isotp: Fix context buffer memory leaks gramsay0/zephyr
2 participants
@henrikbrixandersen @gramsay0