Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http1 dynamic post request response doesn't send header a second time #76776

Closed
LukasTaroza opened this issue Aug 7, 2024 · 4 comments · Fixed by #76845
Closed

http1 dynamic post request response doesn't send header a second time #76776

LukasTaroza opened this issue Aug 7, 2024 · 4 comments · Fixed by #76845
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug

Comments

@LukasTaroza
Copy link

I am using sample http_server and found that if I post to a URL with dynamic context, the first time I get a packet with a header and if I post again without waiting for client timeout, I don't get a header.

Log with additional messages added to show what header is sent:
image

I've added a line client->http1_header_sent = false when status is HTTP_SERVER_DATA_FINAL to fix the issue, but I don't think that is a good fix.

I am using zephyr commit 5305aa6

@LukasTaroza LukasTaroza added the bug The issue is a bug, or the PR is fixing a bug label Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Hi @LukasTaroza! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

@rlubos
Copy link
Contributor

rlubos commented Aug 8, 2024

Thanks for the report, I've managed to reproduce the issue. I'll send a fix shortly.

@rlubos
Copy link
Contributor

rlubos commented Aug 8, 2024

@LukasTaroza #76845

@LukasTaroza
Copy link
Author

Thank you, the fix now sends a header on every request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants