Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: irq: multilevel: the value return from irq_parent_level_3() is wrong #79301

Closed
ycsin opened this issue Oct 2, 2024 · 1 comment · Fixed by #78845 or #79636
Closed

arch: irq: multilevel: the value return from irq_parent_level_3() is wrong #79301

ycsin opened this issue Oct 2, 2024 · 1 comment · Fixed by #78845 or #79636
Assignees
Labels
area: Architectures bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@ycsin
Copy link
Member

ycsin commented Oct 2, 2024

Describe the bug

When Zephyr encodes an IRQ to the second and the third level, the value of the IRQ is incremented by one, as zero means no IRQs present in that level.

So when we want to get the parent IRQ of level 3 with irq_parent_level_3(), the value in the level 2 should be restored by minus 1.

To Reproduce

  1. Run the tests fixed/added in irq: multilevel: fixes and optimizations  #78845 with v3.7-branch
  2. The test should fail

Expected behavior
irq_parent_level_3() should return the correct IRQ and the test should pass

Impact
Applications/drivers that depend on irq_parent_level_3() will get the wrong IRQ value.

Context
This can be closed by backporting the first commit (30aa346) of #78845

@ycsin ycsin added bug The issue is a bug, or the PR is fixing a bug area: Architectures labels Oct 2, 2024
@ycsin ycsin linked a pull request Oct 2, 2024 that will close this issue
@dcpleung dcpleung assigned ycsin and unassigned nashif and dcpleung Oct 2, 2024
@ycsin ycsin reopened this Oct 8, 2024
@ycsin
Copy link
Member Author

ycsin commented Oct 8, 2024

This issue is for the backport, which I havent create yet

@mmahadevan108 mmahadevan108 added the priority: low Low impact/importance bug label Oct 8, 2024
@ycsin ycsin linked a pull request Oct 10, 2024 that will close this issue
@ycsin ycsin closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Architectures bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
4 participants