Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect sourceFileNames in exports #55

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

emre-aki
Copy link
Contributor

@emre-aki emre-aki commented Jun 17, 2022

Summary of the changes

The changes in this PR include

  • Read displayName off of MSDocument and write in the directives for the Mac App to read.
  • Update the pull request template so that it'd be more relevant to the codebase

Checklist

  • My PR has a clear and complete description.
  • I have performed a self-review of my own code.
  • I have considered the security implications of this change.
  • I have tested the changes against older versions of Sketch.

@emre-aki emre-aki self-assigned this Jun 17, 2022
@emre-aki emre-aki changed the base branch from master to develop June 17, 2022 11:20
@emre-aki emre-aki force-pushed the feature/collect-source-file-name branch from ce946bf to 0283fc2 Compare June 17, 2022 11:23
@emre-aki emre-aki force-pushed the feature/collect-source-file-name branch from 0283fc2 to 109f1f6 Compare June 23, 2022 15:32
@emre-aki emre-aki changed the title [ZDI-203] Collect sourceFileNames in exports Collect sourceFileNames in exports Jun 23, 2022
@emre-aki emre-aki requested a review from borulday August 4, 2022 11:04
Copy link
Member

@borulday borulday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the minor comment, LGTM

@emre-aki emre-aki force-pushed the feature/collect-source-file-name branch from b1c1710 to ee23c34 Compare August 4, 2022 13:53
@emre-aki emre-aki merged commit e922df5 into develop Aug 4, 2022
@emre-aki emre-aki deleted the feature/collect-source-file-name branch August 4, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants