Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Remove repeated flag -f from push and set-admin #1123

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

spalladino
Copy link
Contributor

Flag -f was already being used for --from, but was overwritten by both push and set-admin as force. Now --from is the only accepted meaning.

Fixes #1052

Flag -f was already being used for --from, but was overwritten by both push and set-admin as force. Now --from is the only accepted meaning.

Fixes #1052
@spalladino spalladino requested a review from jbcarpanelli July 18, 2019 22:17
Copy link
Contributor

@jbcarpanelli jbcarpanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

push and set-admin were the only two commands where the --force flag was also defined as -f, right?

@jbcarpanelli jbcarpanelli added the status:ready-to-merge Order mergify to merge label Jul 18, 2019
@spalladino
Copy link
Contributor Author

push and set-admin were the only two commands where the --force flag was also defined as -f, right?

Yep!

@mergify mergify bot merged commit f265133 into master Jul 18, 2019
@mergify mergify bot deleted the fix/master-repeated-flag-f-#1052 branch July 18, 2019 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready-to-merge Order mergify to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On the CLI push docs, -f can't be both --force and --from
2 participants