Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --lib flag from prove6 usage #13

Open
ugexe opened this issue Nov 15, 2023 · 0 comments
Open

Remove --lib flag from prove6 usage #13

ugexe opened this issue Nov 15, 2023 · 0 comments

Comments

@ugexe
Copy link

ugexe commented Nov 15, 2023

Just saw this on the Rakudo Weekly News, nice work!

I noticed one thing that I think could be improved: remove the use of --lib with prove6.

From this:

    - name: Run prove6
      if: ${{ inputs.run_prove6 }}
      run: |
        zef install --/test --fetch-degree=${{ env.zef_fetch_degree }} --test-degree=${{ env.zef_test_degree }} App::Prove6

        prove6 --version

        prove6 --jobs ${{ env.zef_test_degree }} --lib --timer --verbose

To this:

    - name: Run prove6
      if: ${{ inputs.run_prove6 }}
      run: |
        zef install --/test --fetch-degree=${{ env.zef_fetch_degree }} --test-degree=${{ env.zef_test_degree }} App::Prove6

        prove6 --version

        prove6 --jobs ${{ env.zef_test_degree }} --timer --verbose

The reason being is the module and its dependencies have been installed, so there is no reason to add lib to the repository chain. More importantly though is that it will end up with the module being precompiled twice: once on the install, and once again when the lib directory gets used (which is different from what just got installed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant