Ts infer optional params from effect handler #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://effector-git-fork-bloadvenro-ts-infer-optional-par-adab11.zerobias.now.sh |
|
Wow, amazing! 😃 Big thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with current createEffect typescript typings is that
FN extends () => infer Donecondition satisfies zero-or-one-arity effect handlers. Handler like(x?: TYPE) => anywill produceEffect<void,...>. New test suite with updated snapshots displays these errors.You may see new typings proposal partially improving current situation. I added some comments to explain why it was difficult to deal with type
any.The last commit contains finally updated snapshots to demonstrate how proposed typings work.