Fix colloc and IPv6 #3161
Merged
Fix colloc and IPv6 #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3154 by:
For Java, I picked the "normalization" provided by https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/net/Inet6Address.html#getHostAddress(), which returns a "long form" of the IPv6 address. We call getHostAddress directly a number of times and this was the simplest normalization.
This is not a complete fix for #3154. We should also normalize IPv6 hosts in C++, C# and JS. In C++ and C#, system APIs appear to return the short form, which is why "::1" works with colloc. We should run at least one test with colloc + ipv6 (not in this PR).