Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer compatible with zeromq/zermq4-x #113

Closed
jgornowich opened this issue Feb 18, 2017 · 3 comments
Closed

no longer compatible with zeromq/zermq4-x #113

jgornowich opened this issue Feb 18, 2017 · 3 comments

Comments

@jgornowich
Copy link

Not sure if this c++ bindings should be compatible with zeromq4-x legacy stable release, but I am using zeromq 4.0.8 and cppzmq will no longer compile because method zmq_msg_gets() does not exist for reference in zmq.hpp:

https://github.com/zeromq/cppzmq/blob/master/zmq.hpp#L376

This may be as simple as changing the VERSION that is referenced in preprocessor directive?

I plan on upgrading to the zeromq/libzmq core engine soon, but I see a use to keep this compatible with legacy stable releases.

Also, are there any plans to create tags for this repo that somehow denote the compatible zeromq library version? Maybe at least a couple that denote compatibility with the two legacy releases 4.0.x and 4.1.x?

@bluca
Copy link
Member

bluca commented Feb 18, 2017

That ifdef should probably be:

#if ZMQ_VERSION >= ZMQ_MAKE_VERSION(4, 1, 0)

instead. Could you please send a PR to fix it?

@jgornowich
Copy link
Author

PR submitted, simple change.

Thanks!

@bluca
Copy link
Member

bluca commented Feb 20, 2017

Merged, thank you!

@bluca bluca closed this as completed Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants