Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable emplace feature for timers #4718

Open
githejie opened this issue Aug 3, 2024 · 0 comments · May be fixed by #4719
Open

Enable emplace feature for timers #4718

githejie opened this issue Aug 3, 2024 · 0 comments · May be fixed by #4719

Comments

@githejie
Copy link
Contributor

githejie commented Aug 3, 2024

Issue description

https://github.com/zeromq/libzmq/blob/master/src/timers.hpp#L70
Using insert to add key-value pairs to this _timers std::multimap container may cause unnecessary copying or moving.
Using emplace instead of insert can construct objects inside the container, thus avoiding unnecessary copying or moving.
@githejie githejie linked a pull request Aug 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable emplace feature for timers githejie/libzmq
1 participant
@githejie