Improve oom handling #2471
Merged
Improve oom handling #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Pass (std::nothrow) as done in all other places.
Solution: Do it unconditionally.
Solution: Use the appropriate assertion macro.
|
@bluca Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues with my application built on top of libzmq in cases of on an out of memory condition. And therefore I also took a look into libzmq itself.
I've fixed a couple of places which used the throwing new version and also added a couple of forgotten asserts. Compiles and all tests pass on debian jessie x64 and x86/x64 Windows 7 with Visual Studio 2015.