Problem: code duplication and unnecessary nesting around ZMQ_THREAD_SAFE querying #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: added .clang-format file
Solution: applied clang-format
Solution: add clang-format to cmake, and add another travis-ci build type
Solution: restrict to src, tests, perf, tools and include directories
Solution: explicitly select clang-5.0
Solution: fix execution directory
Solution: fix CMAKE_MODULES_PATH
querying Solution: remove code duplication and rearrange conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: remove code duplication and rearrange conditions
Note: this requires #2908 to be merged first.