-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to build on mac m1 max #1907
Comments
The workaround is to install zeromq prior to installing pyzmq, e.g. via This is really a libzmq issue. libzmq 4.3.4 cannot be built without libsodium on current macOS with default parameters, and fails with this error. I'm not sure what compiler flags, if any, can fix it. That's a question for libzmq folks. The full error, building zeromq 4.3.4 (entirely without pyzmq):
gives:
I think libzmq 4.3.5 won't have this issue simply because the affected feature has been removed. This, in turn, is part of what's blocking pyzmq's upgrade to 4.3.5, since it's a major breaking change in pyzmq distributions to lose CURVE support. So I have to figure out how to bundle libsodium and replace the abandoned Windows builds of libzmq, which don't exist for 4.3.5 before pyzmq can update the bundled libzmq. So I think this will be closed by #1903. |
if I use |
Ah, no, it should link to the installed libzmq (omit |
I am also seeing this error on fedora 38
Confirm that installing zeromq-devel avoids the problem.
|
@minrk , Im trying to install
|
I dread it a bit, but I feel like this and the removal of tweetnacl from libzmq is going to force me to rewrite bundling to include 'proper' installation of libzmq and libsodium and building via something like scikit-build or meson. I think that will be better in the long run, but figuring out the linking on Windows is going to take a lot of trial and error, and certainly reintroduce lots of build failures fixed over the years on less common platforms. If anyone with C++ knowledge knows what's changed with recent compilers to introduce these failures and what flags and/or patches will keep us limping along while I figure that out, it would be much appreciated and take a lot of pressure off. |
upstream fix appears to be zeromq/libzmq#4480 I'll see if I can apply a patch to the bundled sources |
@minrk , Perfect; Im able to build the wheel with latest |
@iamshreeram thanks! I'll get on making 25.1.2 ASAP, should be Monday at the latest. |
this should be fixed with last month's 25.1.2 |
Please use this template for reporting suspected bugs or requests for help.
Issue description
when build with no=binary and with bundled
run
ZMQ_PREFIX=bundled pip install --no-binary pyzmq pyzmq
shows error:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/vector:372:5: error: static assertion failed due to requirement 'is_same<zmq::secure_allocator_t<unsigned char>, std::allocator<unsigned char>>::value': [allocator.requirements] states that rebinding an allocator to the same type should result in the original allocato
rEnvironment
The text was updated successfully, but these errors were encountered: