Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 9 fails to build zeromq #443

Closed
aminya opened this issue Apr 6, 2021 · 0 comments · Fixed by #444
Closed

Electron 9 fails to build zeromq #443

aminya opened this issue Apr 6, 2021 · 0 comments · Fixed by #444
Labels

Comments

@aminya
Copy link
Member

aminya commented Apr 6, 2021

Describe the bug
This was brought up in Atom/Hydrogen which uses jmp which uses zeromq

n-riesco/jmp#31
nteract/hydrogen#2034

Reproducing

 prebuildify --napi -t 12.0.0 -t electron@9.4.2 --strip
 prebuildify -t electron@9.4.2 --strip
gyp info it worked if it ends with ok
gyp info using node-gyp@7.1.2
gyp info using node@14.15.5 | win32 | x64
gyp info find Python using Python version 3.9.2 found at "C:\Python39\python3.exe"
gyp info find VS using VS2019 (16.10.31025.218) found at:
gyp info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview"
gyp info find VS run with --verbose for detailed information
gyp info spawn C:\Python39\python3.exe
gyp info spawn args [
gyp info spawn args   'C:\\Users\\aminy\\AppData\\Roaming\\npm\\pnpm-global\\4\\node_modules\\.pnpm\\node-gyp@7.1.2\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\aminy\\Documents\\GitHub\\zeromq.js\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\aminy\\AppData\\Roaming\\npm\\pnpm-global\\4\\node_modules\\.pnpm\\node-gyp@7.1.2\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\aminy\\AppData\\Local\\Temp\\prebuildify\\electron\\9.4.2\\include\\node\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\aminy\\AppData\\Local\\Temp\\prebuildify\\electron\\9.4.2',
gyp info spawn args   '-Dnode_gyp_dir=C:\\Users\\aminy\\AppData\\Roaming\\npm\\pnpm-global\\4\\node_modules\\.pnpm\\node-gyp@7.1.2\\node_modules\\node-gyp',
gyp info spawn args   '-Dnode_lib_file=C:\\\\Users\\\\aminy\\\\AppData\\\\Local\\\\Temp\\\\prebuildify\\\\electron\\\\9.4.2\\\\<(target_arch)\\\\node.lib',
gyp info spawn args   '-Dmodule_root_dir=C:\\Users\\aminy\\Documents\\GitHub\\zeromq.js',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'C:\\Users\\aminy\\Documents\\GitHub\\zeromq.js\\build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\MSBuild.exe
gyp info spawn args [
gyp info spawn args   'build/binding.sln',
gyp info spawn args   '/clp:Verbosity=minimal',
gyp info spawn args   '/nologo',
gyp info spawn args   '/p:Configuration=Release;Platform=x64',
gyp info spawn args   '/m:16'
gyp info spawn args ]
  build_libzmq
  Downloading libzmq source...
  Building libzmq...
  CMake Error at CMakeLists.txt:2 (project):
    Generator

      Visual Studio 15 2017 Win64

    could not find any instance of Visual Studio.



  -- Configuring incomplete, errors occurred!
  See also "C:/Users/aminy/Documents/GitHub/zeromq.js/build/libzmq/CMakeFiles/CMakeOutput.log".
C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(240,5
): error MSB8066: Custom build for '..\package.json' exited with code 1. [C:\Users\aminy\Documents\GitHub\zeromq.js\bui
ld\libzmq.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\MSBuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\aminy\AppData\Roaming\npm\pnpm-global\4\node_modules\.pnpm\node-gyp@7.1.2\node_modules\node-gyp\lib\build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
gyp ERR! System Windows_NT 10.0.19042
gyp ERR! command "C:\\Users\\aminy\\AppData\\Local\\emsdk\\node\\14.15.5_64bit\\bin\\node.exe" "C:\\Users\\aminy\\AppData\\Roaming\\npm\\pnpm-global\\4\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=9.4.2" "--devdir=C:\\Users\\aminy\\AppData\\Local\\Temp\\prebuildify\\electron" "--target_arch=x64" "--runtime=electron" "--dist-url=https://atom.io/download/electron" "--release"
gyp ERR! cwd C:\Users\aminy\Documents\GitHub\zeromq.js
gyp ERR! node -v v14.15.5
gyp ERR! node-gyp -v v7.1.2
gyp ERR! not ok
node-gyp exited with 1

Expected behavior

Tested on

  • OS: Win 10
  • ZeroMQ.js version: master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant