Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Run mocha tests with Electron #547

Merged
merged 5 commits into from
Dec 7, 2022
Merged

test: Run mocha tests with Electron #547

merged 5 commits into from
Dec 7, 2022

Conversation

Bartel-C8
Copy link
Contributor

@Bartel-C8 Bartel-C8 commented Dec 6, 2022 •
edited
Loading

Resolves #534

@Bartel-C8
Copy link
Contributor Author

Depends on #546

@Bartel-C8
Copy link
Contributor Author

Resolved merge conflict + fixed mocha test not exiting in CI

@Bartel-C8
Copy link
Contributor Author

Bartel-C8 commented Dec 7, 2022 •
edited
Loading

Rebased again.

aminya
aminya approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@aminya aminya merged commit 1577b8b into zeromq:master Dec 7, 2022
@aminya aminya mentioned this pull request Dec 8, 2022
Closed
@Bartel-C8 Bartel-C8 deleted the electronTests branch December 8, 2022 12:04
@naiba4 naiba4 mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@naiba4 naiba4 mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for Electron
2 participants
@Bartel-C8 @aminya