Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the Windows prebuilds + fix some of the test failures #618

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

aminya
Copy link
Member

@aminya aminya commented Jun 14, 2024

No description provided.

@rotu
Copy link
Contributor

rotu commented Jun 14, 2024

Maybe try bumping prebuildify? prebuild/prebuildify#84
Also, the name of this PR describes the "how" but not the "why". I'd retitle it.

@aminya aminya changed the title fix: use execa for prebiuld script fix: fix the Windows prebuilds + fix some of the test failures Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants