Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few issues with Android build #222

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix a few issues with Android build #222

merged 1 commit into from
Jun 2, 2023

Conversation

bostick
Copy link
Contributor

@bostick bostick commented Jun 2, 2023

  • do not remove miniupnpc/VERSION (unsure what previous problem was)
  • do not need to export PATH
  • do not copy source files, allow gradle to build from source
  • leave outputs from gradle (copy to PKG_OUTPUT_DIR instead of move)

@bostick
Fix a few issues with Android build
0d81706 
* do not remove miniupnpc/VERSION (unsure what previous problem was)
* do not need to export PATH
* do not copy source files, allow gradle to build from source
* leave outputs from gradle (copy to PKG_OUTPUT_DIR instead of move)
@bostick bostick requested a review from joseph-henry June 2, 2023 20:30
@joseph-henry
Copy link
Contributor

joseph-henry commented Jun 2, 2023 •
edited
Loading

This is really great. Thanks.

The reason for moving VERSION was that a previous version of one of the build tools would try to compile it and there wasn't a way to exclude it. If that's no longer the case we can keep it in place.

@joseph-henry joseph-henry merged commit 4aa57d7 into dev Jun 2, 2023
@bostick bostick deleted the brenton/fix-android-build branch July 18, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-henry joseph-henry Awaiting requested review from joseph-henry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bostick @joseph-henry