Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fails #29

Closed
lomenzel opened this issue Jun 21, 2023 · 3 comments
Closed

make fails #29

lomenzel opened this issue Jun 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@lomenzel
Copy link
Contributor

Describe the bug
make fails with:
image

To Reproduce
Steps to reproduce the behavior:

  1. install dependencies
  2. clone repo
  3. $ make
  4. See error

Expected behavior
build and install i guess

Log

leonard@pacon:~/test/polonium$ make
cp -f res/metadata.json pkg/
cp -f res/main.xml pkg/contents/config/
cp -f res/config.ui pkg/contents/ui/
sed -i "s/%VERSION%/0.5.0/" pkg/metadata.json
sed -i "s/%NAME%/polonium/" pkg/metadata.json
npm install

up to date, audited 6 packages in 541ms

found 0 vulnerabilities
tsc
src/engine/btree.ts:219:18 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

219         let ret = new Array<[KWin.AbstractClient, KWin.Tile]>;
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/engine/engine.ts:198:26 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

198         let newDesktops = new Array<Desktop>;
                             ~~~~~~~~~~~~~~~~~~~

src/engine/kwin.ts:49:24 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

49         let stackNext = new Array<Tile>;
                          ~~~~~~~~~~~~~~~~

src/engine/kwin.ts:86:24 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

86         let stackNext = new Array<KWin.Tile>;
                          ~~~~~~~~~~~~~~~~~~~~~

src/engine/kwin.ts:112:18 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

112         let ret = new Array<[KWin.AbstractClient, KWin.Tile | null]>;
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/engine/threecolumn.ts:15:36 - error TS1109: Expression expected.

15     columns = [new Array<Container>, new Array<Container>, new Array<Container>];
                                      ~

src/engine/threecolumn.ts:15:58 - error TS1109: Expression expected.

15     columns = [new Array<Container>, new Array<Container>, new Array<Container>];
                                                            ~

src/engine/threecolumn.ts:15:59 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

15     columns = [new Array<Container>, new Array<Container>, new Array<Container>];
                                                             ~~~~~~~~~~~~~~~~~~~~~

src/engine/threecolumn.ts:18:14 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

18     nodeMap = new BiMap<Container, KWin.Tile>;
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/main.ts:15:19 - error TS1384: A 'new' expression with type arguments must always be followed by a parenthesized argument list.

15     let desktops = new Array<Desktop>;
                     ~~~~~~~~~~~~~~~~~~~


Found 10 errors.

make: *** [Makefile:44: src] Error 2
leonard@pacon:~/test/polonium$ 

Additional context
may be my fault, but couldnt figure out what i did wrong :)

@lomenzel lomenzel added the bug Something isn't working label Jun 21, 2023
@zeroxoneafour
Copy link
Owner

Very strange, I've never seen that before. When I looked it up, apparently its been an error since 2020?

I'll just add parentheses to the new expressions later.

@zeroxoneafour
Copy link
Owner

Should be fixed now

@cig0
Copy link

cig0 commented Jun 22, 2023

Hi all,
@zeroxoneafour I confirm it builds successfully, thanks.
There's this error message about the metadata, though:

kpackagetool5 -t KWin/Script -s polonium \
        && kpackagetool5 -u polonium.kwinscript \
        || kpackagetool5 -i polonium.kwinscript
Error: Can't find plugin metadata: polonium
Successfully installed /var/home/cig0/w/polonium/polonium.kwinscript

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants