Skip to content

Commit

Permalink
Stop using process.umask() (#28)
Browse files Browse the repository at this point in the history
It's deprecated in the latest Node.js due to being insecure and
it's not necessary to use it in the first place because the umask
is automatically applied when creating the directory.

Refs: nodejs/node#32321
Refs: isaacs/node-mkdirp#22
  • Loading branch information
bnoordhuis committed May 30, 2020
1 parent 0b9eae0 commit a3a45cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion v8-compile-cache.js
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ class NativeCompileCache {
//------------------------------------------------------------------------------

function mkdirpSync(p_) {
_mkdirpSync(path.resolve(p_), parseInt('0777', 8) & ~process.umask());
_mkdirpSync(path.resolve(p_), 0o777);
}

function _mkdirpSync(p, mode) {
Expand Down

0 comments on commit a3a45cd

Please sign in to comment.