Add arch to cache directory #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungsters
force-pushed
the
arch
branch
2 times, most recently
from
972c039
to
f57ba31
Compare
|
@zertosh mentioned he'll take a look tonight. |
yungsters
force-pushed
the
arch
branch
2 times, most recently
from
6f341e0
to
5fcf5ff
Compare
|
@zertosh, let me know if there's any changes you'd like me to make to this pull request. Thanks! |
This was referenced Aug 14, 2023
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D48336030 fbshipit-source-id: 0c54a95a485bbdb418681fa494427d0b3b8a84b7
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Aug 14, 2023
Summary: Pull Request resolved: facebook#39012 Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D48336030 fbshipit-source-id: 5cf68aea0abed1a4081d0182f5fb9ef5b16511c5
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: facebook#39012 Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: zertosh, NickGerleman Differential Revision: D48336030 fbshipit-source-id: 59e772d777e0775a9bd7c31218025cc2f34a1979
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Aug 15, 2023
Summary: X-link: facebook/react-native#39012 Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: zertosh, NickGerleman Differential Revision: D48336030 fbshipit-source-id: afa73d1f00bff826a8b76fa09949b9d35a97905b
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: #39012 Upgrades many of our projects to `v8-compile-cache@^2.4.0`, which includes [zertosh/v8-compile-cache#45](zertosh/v8-compile-cache#45). This fixes a very opaque segmentation fault when `v8-compile-cache` is used on Apple Silicon with mixed architecture modes. This also upgrades our projects to `eslint@^2.3.1`, which no longer has the dependency on an outdated version of `v8-compile-cache`. Changelog: [Internal] Reviewed By: zertosh, NickGerleman Differential Revision: D48336030 fbshipit-source-id: afa73d1f00bff826a8b76fa09949b9d35a97905b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing issues on Apple Silicon device where the following would segmentation fault:
This change fixes the problem.
Test Plan:
Verify tests pass.
Verify the architecture test fails on Apple Silicon without the
archfix:Verify the architecture test succeeds with the
archfix: