Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Betafix] fix 2510 - Corrige les slugs des MPs #2513

Merged
merged 1 commit into from
Apr 7, 2015

Conversation

Situphen
Copy link
Member

@Situphen Situphen commented Apr 7, 2015

Q R
Correction de bugs ? non
Nouvelle Fonctionnalité ? non
Tickets (issues) concernés #2510

QA : Vérifier que le slug est correct

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling e96c03e on Situphen:betafix-2510 into 309090d on zestedesavoir:release-v1.7.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 5b9b667 on Situphen:betafix-2510 into 309090d on zestedesavoir:release-v1.7.

@@ -202,7 +202,7 @@ def post(self, request, *args, **kwargs):
except ObjectDoesNotExist:
messages.warning(request, _(u'Le membre que vous avez essayé d\'ajouter ne peut pas être contacté.'))

return redirect(reverse('private-posts-list', args=[self.object.pk, self.object.slug]))
return redirect(reverse('private-posts-list', args=[self.object.pk, self.object.slug()]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu es sur de toi ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Théoriquement, vu que ça touche aux urls, c'est correct. @GerardPaligot : tu confirmes ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, oui, c'est la modification que j'indiquais ici.

@Eskimon
Copy link
Contributor

Eskimon commented Apr 7, 2015

Point de vue QA tout marche comme prévu, tout du moins le bug a bien disparu et aucun comportement étrange n'apparait :) je merge !

Eskimon added a commit that referenced this pull request Apr 7, 2015
[Betafix] fix 2510 - Corrige les slugs des MPs
@Eskimon Eskimon merged commit e6de7d6 into zestedesavoir:release-v1.7 Apr 7, 2015
@Situphen Situphen deleted the betafix-2510 branch May 23, 2015 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants