Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More advanced key management for ZetaClient (hotkey) #1278

Closed
Tracked by #1035
lumtis opened this issue Oct 11, 2023 · 1 comment · Fixed by #1323
Closed
Tracked by #1035

More advanced key management for ZetaClient (hotkey) #1278

lumtis opened this issue Oct 11, 2023 · 1 comment · Fixed by #1323
Assignees
@lumtis
Labels
security Security Issues / Concern zetaclient Issues related to ZetaClient

Comments

@lumtis
Copy link
Member

lumtis commented Oct 11, 2023

We currently use the keyring backend test for the key used by ZetaClient

node/zetaclient/keys.go

Line 95 in f51f6e0

return ckeys.New(sdk.KeyringServiceName(), ckeys.BackendTest, cliDir, reader, cdc)

We need to allow more advanced keys management with the ZetaClient
@lumtis lumtis added zetaclient Issues related to ZetaClient security Security Issues / Concern priority:1 labels Oct 11, 2023
@lumtis lumtis self-assigned this Oct 12, 2023
@lumtis
Copy link
Member Author

lumtis commented Oct 12, 2023 •
edited
Loading

An improvement is to use ckeys.BackendFile

The password would need to be remove from hardcoded

broadcast.go needs additional logic for password prompting

ctx  = ctx.WithInput(r)
r.Write(fmt.Sprintf("%s\n%s\n", p,  p))

@lumtis lumtis changed the title More advanced key management for ZetaClient More advanced key management for ZetaClient hotkey Oct 16, 2023
@lumtis lumtis changed the title More advanced key management for ZetaClient hotkey More advanced key management for ZetaClient (hotkey) Oct 16, 2023
@lumtis lumtis mentioned this issue Oct 16, 2023
Closed
@lumtis lumtis removed the priority:1 label Oct 20, 2023
This was referenced Oct 20, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumtis lumtis

Labels
security Security Issues / Concern zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(zetaclient): use keyring backend file for hotkey zeta-chain/node
1 participant
@lumtis