Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observer : refactor Add observer #1349

Closed
Tracked by #1035
kingpinXD opened this issue Oct 26, 2023 · 2 comments
Closed
Tracked by #1035

observer : refactor Add observer #1349

kingpinXD opened this issue Oct 26, 2023 · 2 comments
Assignees

Comments

@kingpinXD
Copy link
Contributor

Add observer TX can be broken down into

  • Add Node Account
  • Add Observer
@lumtis
Copy link
Member

lumtis commented Oct 26, 2023

We already the boolean AddNodeAccountOnly in MsgAddObserver, can't it be already used for this?

@kingpinXD
Copy link
Contributor Author

Closing this task, as Add Node Account cannot be reused for Update Observer.
We should only update the operator's address.

Updating the hotkey will cause issues with signing outbound tx's as the TSS server uses the hotkey publickey to generate the peer id stored in the address book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants