-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RemoveInboundTracker
#1345
Comments
It would be good, but I feel it might be lower on our priority list . We could add more stringent checks before creating the tracker first. What do you think? |
Ok, thanks for the context, it sounds good to let this issue aside for the time being. |
I was thinking about the other direction; |
RemoveFromInTxTracker
RemoveInboundTracker
Trackers with expiry would mean
I dont think adding more logic in the begin block is preferable , as it is harder to test and not under active control. If we decide to go with the tx route I guess , implementing the original msg to delete the tracker is much simpler than having an expiry mechanism and deleting expired tracker |
Confirminf as this issue is quite onl All the admin messages related to trackers are under Emergency group now, I think we should add the new MsgRemoveInboundTracker under the same group |
We currently have the message
RemoveFromOutTxTracker
that allows to manually remove a out tx tracker by an admin group 1.node/x/crosschain/keeper/keeper_out_tx_tracker.go
Line 157 in 9028fe3
Would it make sense to have a similar mechanism for InTx tracker ?
cc @kingpinXD
The text was updated successfully, but these errors were encountered: