Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll list into view when filtering event participants #1300

Closed
1 task done
richardolsson opened this issue May 6, 2023 · 0 comments · Fixed by #1536
Closed
1 task done

Scroll list into view when filtering event participants #1300

richardolsson opened this issue May 6, 2023 · 0 comments · Fixed by #1536
Assignees
Labels
💡 enhancement New feature or request 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue.

Comments

@richardolsson
Copy link
Member

richardolsson commented May 6, 2023

Description

A user is now able to filter participants in the event participants list, a feature which was introduced by #1285. However, there is a potential problem on this page for users on small screens, which is that they may see the filter feature without seeing the list, which is further down the page.

One solution would be to scroll the list into view when the user starts filtering, either onFocus or the first onFilterChange (perhaps better). This will require some experimentation to make sure it feels right.

Relevant Job Stories

None

Prerequisites

None

Requirements

Possible implementations

I'm guessing there will need to be a ref on the first list, and that scrollIntoView() can be used with the smooth behaviour.

Design specifications

This is the context (note how the actual list being filtered is outside of the window below the fold, while the input field is not):

image

Open questions

When to trigger the scroll exactly? Let's experiment!

@richardolsson richardolsson added 💡 enhancement New feature or request 🚪 entry-level Good for newcomers labels May 6, 2023
@richardolsson richardolsson added the 🐬 Medium Just a nice sized issue. label Jun 2, 2023
@kaulfield23 kaulfield23 self-assigned this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement New feature or request 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants