Label "Convert to static view" does not sufficiently communicates that view will be cleared

[ev-sc]

Description

When you click "convert to static view" from a smart view, the view is cleared - all rows are deleted.

Expected Behaviour

UI is correctly labelled and/or warns before deletion

Actual Behaviour

UI does not inform that row deletions will take place

Steps to reproduce

1. Go to any single smart search view page
2. Click on "convert to static view"

[richardolsson]

The easiest way to fix this (as suggested by @lowlandjuju elsewhere) would be to just change the label of this menu item, to indicate somehow that the view will be cleared as part of the "conversion".

Another option is to actually keep the content, as suggested in #533. I've explained in a comment on that issue what actually happens behind the scenes, the most important of which is this:

Turning a dynamic view into a static view means deleting the associated Smart Search query. This causes the API to start returning any statically defined rows instead. If none had previously been added, the view will be empty.

This is destructive only in the sense that the query is lost. You could attach an identical query and get back the same results as before converting, but you would have to configure that query yourself and if it was complex that might be difficult. If you do attach a query again (identical or otherwise) any people that were previously "in the view" will return as if nothing happened.