Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1469/user-language #1515

Merged
merged 1 commit into from
Sep 19, 2023
Merged

issue-1469/user-language #1515

merged 1 commit into from
Sep 19, 2023

Conversation

djbusstop
Copy link
Collaborator

@djbusstop djbusstop commented Sep 8, 2023

Description

This PR allows the user lang set in the user settings to override the browser language.

Changes

  • Adds
    • property lang to ZetkinUser type
  • Changes
    • lang returned from scaffold now first checks for user.lang and uses that if there is a value, otherwise defaults to browser language.

Related issues

Resolves #1469

Copy link
Contributor

@rebecarubio rebecarubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and works great! Nice fix! 🚀

@rebecarubio rebecarubio merged commit f6dad06 into main Sep 19, 2023
4 checks passed
@rebecarubio rebecarubio deleted the issue/1469-user-language branch September 19, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User language ignored
2 participants