Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1398/location search options #1533

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

kaulfield23
Copy link
Contributor

@kaulfield23 kaulfield23 commented Sep 13, 2023

Description

This PR fixes a bug that autocomplete location list doesn't appear on focus in map. I also sorted a location list alphabetically.

Screenshots

Mozilla.Firefox.2023-09-13.16-06-16.mp4

Changes

  • Adds useMemo for sorting event location list in EventOveriewCard
  • Spread params.InputProps in TextField

Notes to reviewer

I was thinking it could be nice to have a alphabetically sorted list, so I fixed it together with this issue

Related issues

Resolves #1398

Copy link
Contributor

@rebecarubio rebecarubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I´ve tested and it works perfect 🎉 also the code lgtm! Soooo cool to have this fixed!

@rebecarubio rebecarubio merged commit 3914266 into main Sep 15, 2023
4 checks passed
@rebecarubio rebecarubio deleted the issue-1398/location-search-options branch September 15, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location Model Autocomplete Search not showing options in map view
2 participants