Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-1300/scrollIntoView #1536

Merged
merged 1 commit into from
Sep 15, 2023
Merged

issue-1300/scrollIntoView #1536

merged 1 commit into from
Sep 15, 2023

Conversation

kaulfield23
Copy link
Contributor

Description

This PR scrolls down to the filtered list in participants when typing some character in search field.

Screenshots

Mozilla.Firefox.2023-09-14.14-44-09.mp4

Changes

  • Adds scrollIntoView to onFilterChange

Notes to reviewer

Related issues

Resolves #1300

rebecarubio
rebecarubio approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@rebecarubio rebecarubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we could do this nice thing and so smooth 😱 ! I´ve tried it "to the edge" and works really nice! Good job 🚀

@rebecarubio rebecarubio merged commit ad09fd4 into main Sep 15, 2023
4 checks passed
@rebecarubio rebecarubio deleted the issue-1300/filtering-scroll-view branch September 15, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebecarubio rebecarubio rebecarubio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll list into view when filtering event participants
2 participants
@kaulfield23 @rebecarubio