Survey signature #1665
Merged
Survey signature #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrycatalinismith
force-pushed
the
issue-1620/survey-signature
branch
from
53d904c to
933c9dc
Compare
| ); | ||
|
|
||
| const selectedStyle = { | ||
| backgroundColor: '#fbcbd8', |
There was a problem hiding this comment.
@richardolsson I've not been able to track down this color or a similar one in the theme to satisfy your comment. Want me to add it? Or is this just my lack of familiarity with the theme?
There was a problem hiding this comment.
Let's leave it as is for now until we get some designers to look at this before launching it. Thanks for pointing it out!
Closed
richardolsson
approved these changes
Dec 3, 2023
| ); | ||
|
|
||
| const selectedStyle = { | ||
| backgroundColor: '#fbcbd8', |
There was a problem hiding this comment.
Let's leave it as is for now until we get some designers to look at this before launching it. Thanks for pointing it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The survey signature functionality in the new survey page was one of the biggest missing pieces of the puzzle. This PR attempts to square it away.
I've localized all the strings, added playwright tests for all three code paths, made it preserve all user input in case of a backend error, added some vertical space between the text input fields, and tidied up some of the type definitions. Really enjoying working on this stuff very much indeed!
Here's a before/after showing the impact that the improved semantics here have on the screen reader UX.
You can see that VoiceOver is now able to understand the relationship between the radio buttons and the label.