Undocumented survey select widget bug #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
merged commit 867db13
into
issue-1620/next-v13-survey-page-with-app-router-and-server-action
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an undocumented bug in the new survey page. This bug recently surfaced in the production Gen2 version of Zetkin, and since the code in #1756 was based on the logic from there, I guessed (correctly) that the bug would exist here as well.
The bug basically means that if a
<select>is not interacted with, it will still be submitted (at least on Chrome) with an empty value, and that empty value will not be handled correctly on the server. Instead of removing it, or submitting it with empty options (options: []) it gets submitted with anulloption (options: [null]).Screenshots
None
Changes
page.goto) until within the test cases, to allow for test cases to make additional mocks before navigatingprepareSurveyApiSubmission()that reproduces the bugprepareSurveyApiSubmission()Notes to reviewer
None
Related issues
Undocumented