Add support for the full suite of survey question options in the new survey form #1871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating another side branch off of #1756 in order to make a nice clean space for us to nail down these last little details. There's a bunch of stuff like
hidden
andrequired
that needs to be handled properly by the new survey form components, and also needs playwright tests to keep an eye on it. To get the ball rolling, I've begun here with therequired
property on the text questions as it's probably the simplest.It raises a few little questions.
(required)
on the end of the label. Even just an asterisk on the end is sufficient. (https://www.w3.org/TR/WCAG20-TECHS/H90.html)submits responses
test has become long enough that its size is beginning to obscure the intent of the individual assertions. So I've kind of sketched out some possible ways of splitting things up more, but haven't invested a lot of love into the ideas there.Dropping this here already now in a fairly raw initial state just for the benefit of having the progress so far out of my head and onto a real PR. Whatever ideas come to mind from reading this, throw them my way.