-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1722/sub org survey read only #1941
Conversation
…pListData interface
…action in campaign store
…ning card when shared
…ed to share with us in breadcrumb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I began reviewing this but didn't finish so I didn't publish my comment. I'm publishing them now and will continue to review the rest of the PR as soon as I can, but most likely not until next week.
Come to think of it, I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this! I think it's really nice. I've looked at the code and played around with the preview build. There were some texts that I feel could be improved when I saw them in place, but then I think it's ready to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With those minor changes to the messages I think this is ready to merge now. Nice work! 🎉
Just fixed a merge conflict! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full speed ahead! 🚀
Description
This PR fixes a bug where sub-organizations were able to edit the original survey shared by the parent organization. It also implements a 'shared with us' project in overview which makes it easier for users to find shared activities.
Screenshots
Shared with us
Changes
.tsx
to.ts
of hooks in organization dirisReadOnly
toZUIDateRangePicker
andZUIEditTextInPlace
<Alert/>
toTabbedLayout
shared/index.tsx
,shared/acitivities.tsx
andshared/archive.tsx
SharedCard.tsx
Notes to reviewer
Related issues
Resolves #1722