Display title of current organization in confirmation dialog #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting delete event type
richardolsson
requested changes
Dec 4, 2024
| deleteMessage: m<{ eventType: string }>( | ||
| 'Are you sure you want to delete the "{eventType}" event type for the whole organization?' | ||
| currentDefaultOrgMsg: m('the current organization'), | ||
| deleteMessage: m<{ eventType: string; orgTitle: string }>( |
There was a problem hiding this comment.
Changing a message like this (adding properties) is risky, because there might be translations that don't include the property. I think we should give the message a new name.
| @@ -250,6 +253,7 @@ const EventTypeAutocomplete: FC<EventTypeAutocompleteProps> = ({ | |||
| }, | |||
| warningText: messages.type.deleteMessage({ | |||
| eventType: option.title, | |||
| orgTitle: orgTitle ? orgTitle : currentDefaultOrgMsg, | |||
There was a problem hiding this comment.
Under no normal circumstances should orgTitle be undefined on this page. If it is, it should be temporary (while loading) and I'm thinking we can fallback to an empty string or something. That way, we don't need to have two separate messages.
richardolsson
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR displays the name of the current organization in the confirmation dialog on selecting delete event type from an event.
Screenshots
Changes
Notes to reviewer
Not at all sure this is a good solution, even if it seems to work as intended on my end. If not, I would be happy for a hint about the right direction.
Related issues
Resolves #2400