Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

semantic versioning #110

Closed
rade opened this issue Oct 9, 2014 · 6 comments
Closed

semantic versioning #110

rade opened this issue Oct 9, 2014 · 6 comments
Labels

Comments

@rade
Copy link
Member

rade commented Oct 9, 2014

Currently (as of #10) the weave router container versioning uses the github revision. In #33 we plan to introduce versioning of the weave script. And #34 covers compatibility checking between the two. It's hard to see how we can do the latter w/o semantic versioning. And, more generally, semantic versioning is useful to our users. See, e.g. #109.

@hesco
Copy link

hesco commented Oct 9, 2014

Thanks rade, for moving this request forward.

As a way to get you going on the implementation of this requested feature,
let me share with you code I just committed to the hesco-weave puppet module project.

See specifically:
https://github.com/hesco/hesco-weave/blob/master/Makefile
https://github.com/hesco/hesco-weave/blob/master/scripts/set_version.sh

These two files implement the architecture I had suggested in #109,
for the puppet module I am working on. You know, that geese and gander thing.

Hope this permits you to quickly deliver so that I can enable upgrade/downgrade
of the weave script in the puppet module for managing a weave installation.

Thanks again.
-- Hugh

@hesco
Copy link

hesco commented Oct 9, 2014

Also, at the risk of stating the obvious, I would urge that the versions
for the router container and for the script be the same version.
No reason I can think of to manage two distinct versions numbers for them.
It would simplify determination of compatibility.

@hesco
Copy link

hesco commented Oct 15, 2014

A wrinkle I at first missed of the semantic versioning standard published at semver.org is the no-leading zero's rule. In the code above, I depend on the user to set the major and minor versions (with git tag) and let this script set the patch version (using git describe --tags). Next iteration, I will add a check for the leading zero rule and abort the make release process if one is found. The puppet forge is apparently wired to reject package uploads which include leading zeros in their version numbers.

hesco added a commit to hesco/weave that referenced this issue Nov 3, 2014
@hesco
Copy link

hesco commented Nov 3, 2014

#165

@errordeveloper
Copy link
Contributor

I think this can be close as #263 has landed.

@rade
Copy link
Member Author

rade commented Dec 30, 2014

Closed by #263.

@rade rade closed this as completed Dec 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants