Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changed newline_behavior of tinyMCE to 'linebreak' #515

Merged
merged 4 commits into from
Jan 17, 2024
Merged

feat: changed newline_behavior of tinyMCE to 'linebreak' #515

merged 4 commits into from
Jan 17, 2024

Conversation

giuliano176
Copy link
Contributor

No description provided.

@giuliano176 giuliano176 requested a review from a team as a code owner January 9, 2024 15:04
nubsthead
nubsthead previously approved these changes Jan 10, 2024
View reviewed changes
@dhavaldodiya dhavaldodiya self-requested a review January 10, 2024 09:02
@giuliano176 giuliano176 marked this pull request as draft January 10, 2024 09:55
@giuliano176
Copy link
Contributor Author

converting to draft to give the time to the designers to consider further improvements

@giuliano176 giuliano176 marked this pull request as ready for review January 12, 2024 11:59
nubsthead
nubsthead reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@nubsthead nubsthead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the wanted behaviour? In this way users can't add a default p

@giuliano176
Copy link
Contributor Author

Is this the wanted behaviour? In this way users can't add a default p

it's a compromise, validated by Manuel. in the future we will introduce the possibility of formatting the line height (with an external plugin)

@giuliano176 giuliano176 requested a review from nubsthead January 16, 2024 12:04
@giuliano176 giuliano176 merged commit e14796b into devel Jan 17, 2024
2 checks passed
@giuliano176 giuliano176 deleted the IRIS-4935-improve-email-readability-and-formatting branch February 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnekoz gnekoz gnekoz approved these changes

@dhavaldodiya dhavaldodiya dhavaldodiya approved these changes

@nubsthead nubsthead nubsthead approved these changes

@FrancescoGottardi FrancescoGottardi Awaiting requested review from FrancescoGottardi FrancescoGottardi is a code owner automatically assigned from zextras/crabonions

@eugeniamuff eugeniamuff Awaiting requested review from eugeniamuff eugeniamuff is a code owner automatically assigned from zextras/crabonions

@MatteoPerdon MatteoPerdon Awaiting requested review from MatteoPerdon MatteoPerdon is a code owner automatically assigned from zextras/crabonions

Assignees
No one assigned
Labels
validated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giuliano176 @gnekoz @dhavaldodiya @nubsthead @MatteoPerdon