fix: avoid loading fonts from ds to prevent slow loading of module #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fonts loaded from DS bundle are slowing down a lot the loading of the modules since the request to download the inline font is taking more than 2 seconds to response. Restore the usage of @fontsource/roboto to load a local copy of the fonts. Update webpack config to place the fonts where fontsource is loading them from. refs: SHELL-31
- @zextras/carbonio-ui-sdk 1.5.0 refs: SHELL-31
beawar
requested review from
nubsthead,
giuliano176,
dhavaldodiya,
FrancescoGottardi,
gnekoz and
a team
as code owners
CataldoMazzilli
approved these changes
Jan 31, 2023
gnekoz
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fonts loaded from DS bundle are slowing down a lot the loading of the modules since the request to download the inline font is taking more than 2 seconds to response.
Restore the usage of @fontsource/roboto to load a local copy of the fonts. Update webpack config to place the fonts where fontsource is loading them from.
refs: SHELL-31