Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add link in toolbar and use link instead of quicklink #432

Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix: add link in toolbar and use link instead of quicklink #432

merged 4 commits into from
Jun 12, 2024

Conversation

frisonisland
Copy link
Contributor

@frisonisland frisonisland commented Jun 6, 2024 •
edited
Loading

Found display: flex breaks quicklink menu visualization.
Added "link" item in toolbar to allow inserting a link

Refs: CO-1146

@frisonisland
fix: add link in toolbar + remove display flex
7ded987 
- display: flex breaks quicklink menu visualization
@frisonisland frisonisland changed the title fix: add link in toolbar + remove display flex fix: [CO-1146] add link in toolbar + remove display flex Jun 6, 2024
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (63.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

1 similar comment
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (63.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@frisonisland frisonisland marked this pull request as ready for review June 6, 2024 10:42
@frisonisland frisonisland requested review from a team as code owners June 6, 2024 10:42
beawar
beawar reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, follow the commit rules defined for the front-end projects (you can find them in the internal coding manifesto).
The issue code should go in the Refs field of the footer.

src/store/integrations/composer.tsx Outdated Show resolved Hide resolved
@frisonisland frisonisland changed the title fix: [CO-1146] add link in toolbar + remove display flex fix: add link in toolbar + remove display flex Jun 6, 2024
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (62.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar beawar self-requested a review June 12, 2024 13:39
beawar
beawar approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mine is a tech-review only

@beawar
Copy link
Contributor

beawar commented Jun 12, 2024 •
edited
Loading

@frisonisland Do we need to wait for the ux validation before merging this one?

@frisonisland
Copy link
Contributor Author

@frisonisland Do we need to wait for the ux validation before merging this one?

No thanks, you can merge 🙂

@frisonisland frisonisland changed the title fix: add link in toolbar + remove display flex fix: add link in toolbar and use link instead of quicklink Jun 12, 2024
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (62.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar beawar merged commit 48e6dea into devel Jun 12, 2024
3 checks passed
@beawar beawar deleted the fix/CO-1146-hyperlink-difficult-to-create branch June 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beawar beawar beawar approved these changes

@AlessioCoser AlessioCoser AlessioCoser approved these changes

@FrancescoGottardi FrancescoGottardi FrancescoGottardi approved these changes

@giuliano176 giuliano176 Awaiting requested review from giuliano176

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frisonisland @CLAassistant @beawar @AlessioCoser @FrancescoGottardi