Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow update of account signatures #462

Merged
merged 10 commits into from
Jul 10, 2024

Conversation

dhavaldodiya
Copy link
Contributor

@dhavaldodiya dhavaldodiya commented Jul 8, 2024

Expose the updateAccount function to update the identities and signatures in account store.

Refs: SHELL-230 CO-1136

@dhavaldodiya dhavaldodiya requested review from a team as code owners July 8, 2024 09:29
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 97.10% Coverage (63.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (5.20% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

mbarto
mbarto previously approved these changes Jul 8, 2024
@beawar beawar changed the title Shell 230 update account signatures feat: allow update of account signatures Jul 8, 2024
src/store/account/utils.test.ts Outdated Show resolved Hide resolved
src/store/account/utils.test.ts Outdated Show resolved Hide resolved
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 97.10% Coverage (63.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (5.20% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@dhavaldodiya dhavaldodiya requested review from beawar and mbarto July 10, 2024 08:13
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 97.10% Coverage (63.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (5.20% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar beawar merged commit fd240f2 into devel Jul 10, 2024
3 checks passed
@beawar beawar deleted the SHELL-230-update-account-signatures branch July 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants