it is really huge incompatibility change in Bvb_Grid::getParam

[imonteiro]

Original author: martin.m...@gmail.com (July 05, 2011 09:22:02)

that change is for me also not logical

• there is protected variable _ctrlParams
• there are methods to manipulate this array
• internaly _ctrlParams is accessed directly
• you introduced now some getParamClean which is using zend request object to access parameters passed - which is very different from _ctrlParams
• and in the same time you change getParam to also use request object instead of _ctrlParams
• _ctrlParams should be filled/initialized with values from request object, but later request object should not be used to read the data
• this breaks jqgrid completly and I doubt it is correct for other parts of Bvb

Solution:

• I am going to revert changes in getParam
• I am going to add getRequestParamClean and getRequestParam to support your needs

Original issue: http://code.google.com/p/zfdatagrid/issues/detail?id=718

[imonteiro]

From martin.m...@gmail.com on July 05, 2011 09:30:27
introduction of getGridId was not very general step:

• the Bvb classes are always executed for one and only one grid, an instance of Bvb grid does not care about other instances on the same HTML page
• the deploy class is responsible for building request parameters to execute actions
• but currently the deploy class is not involved into request parameter parsing
• in my opinion, deploy class should initialize _ctrlParam on grid initialization
• for example in case of ajax request the GridID is completly unimportant

[imonteiro]

From martin.m...@gmail.com on July 05, 2011 09:36:19
my changes implemented in rev1802, pls. review

[imonteiro]

From bento.vi...@gmail.com on July 15, 2011 02:15:59
Hi Martin,

Sorry for the late answer.

This shouldn't be on trunk. My mistake.

I was investigating some reports that $grid->getParam() does not work but $grid->getRequest()->getParam() works.

Thanks for noticing.

Best Regards,
Bento Vilas Boas