Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of no photos, like Facebook application does #38

Closed
AnthonyMDev opened this issue Nov 5, 2015 · 14 comments
Closed

Allow selection of no photos, like Facebook application does #38

AnthonyMDev opened this issue Nov 5, 2015 · 14 comments

Comments

@AnthonyMDev
Copy link
Collaborator

Right now, if I select zero photos, the select button goes away and only cancel is available.

If the user already has photos selected and would like to remove all selected photos, I'd like to be able to select zero photos and push Done. This is the current functionality in the Facebook iOS application, and I'd love to see that functionality make it's way into this library.

Thanks!

@zhangao0086
Copy link
Owner

Hi @AnthonyMDev

You are so right! I didn't think about it before! I'll appreciate it If you make a pull request to me :)

@AnthonyMDev
Copy link
Collaborator Author

I can make the PR. Quick question, I'm thinking that this should remove the button text that says Select(#) with the # being updated as you select images. Currently, Facebook just has a static Done button. Is that okay? Or would you like to keep that functionality and just switch it to say Done when there are 0?

I'm also thinking this means we remove the Cancel button?

@zhangao0086
Copy link
Owner

I think Facebook is right that Cancel button is not necessary. And I would like to keep that Select and switch it to Done when there are 0 as you said :)

@AnthonyMDev
Copy link
Collaborator Author

I got busy this week and forgot about this, sorry! I'll try to get to it next week.

@zhangao0086
Copy link
Owner

Never mind :)

@AnthonyMDev
Copy link
Collaborator Author

Why never mind? I plan on working on this now. Do you not want to pull it anymore?

@AnthonyMDev
Copy link
Collaborator Author

Alright, I've finished this with PR #41.

@zhangao0086 Hope that works for you. I'd love to see a new version of the pod with this included soon!

Thanks.

@zhangao0086
Copy link
Owner

I'm sorry for my words! I mean "Never mind" for your "sorry". Actually, I'm glad to see your PR. There is no doubt that will help the pod gets better!🍺🍺🍺

@zhangao0086
Copy link
Owner

Thanks for your PR!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants