-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selection of no photos, like Facebook application does #38
Comments
Hi @AnthonyMDev You are so right! I didn't think about it before! I'll appreciate it If you make a pull request to me :) |
I can make the PR. Quick question, I'm thinking that this should remove the button text that says I'm also thinking this means we remove the |
I think Facebook is right that |
I got busy this week and forgot about this, sorry! I'll try to get to it next week. |
Never mind :) |
Why never mind? I plan on working on this now. Do you not want to pull it anymore? |
Alright, I've finished this with PR #41. @zhangao0086 Hope that works for you. I'd love to see a new version of the pod with this included soon! Thanks. |
I'm sorry for my words! I mean "Never mind" for your "sorry". Actually, I'm glad to see your PR. There is no doubt that will help the pod gets better!🍺🍺🍺 |
Thanks for your PR!!! |
Right now, if I select zero photos, the select button goes away and only cancel is available.
If the user already has photos selected and would like to remove all selected photos, I'd like to be able to select zero photos and push
Done
. This is the current functionality in the Facebook iOS application, and I'd love to see that functionality make it's way into this library.Thanks!
The text was updated successfully, but these errors were encountered: