From 7ba90afa315275b4140b54a537e613307086e863 Mon Sep 17 00:00:00 2001 From: Zhao Song Date: Fri, 26 Apr 2024 12:57:12 -0700 Subject: [PATCH] review comment --- .../openjdk/skara/issuetracker/jira/JiraIssue.java | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java b/issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java index ef93db6dc..b80b75660 100644 --- a/issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java +++ b/issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java @@ -39,6 +39,7 @@ public class JiraIssue implements IssueTrackerIssue { private final JiraProject jiraProject; private final RestRequest request; private final JSONValue json; + private final boolean needSecurity; private final Logger log = Logger.getLogger("org.openjdk.skara.issuetracker.jira"); @@ -54,6 +55,7 @@ public class JiraIssue implements IssueTrackerIssue { this.labels = json.get("fields").get("labels").stream() .map(s -> new Label(s.asString())) .collect(Collectors.toList()); + this.needSecurity = jiraProject.jiraHost().visibilityRole().isPresent(); } @Override @@ -84,6 +86,11 @@ public String title() { @Override public void setTitle(String title) { + if (needSecurity) { + log.warning("Issue title does not support setting a visibility role - ignoring"); + return; + } + var query = JSON.object() .put("fields", JSON.object() .put("summary", title)); @@ -101,6 +108,11 @@ public String body() { @Override public void setBody(String body) { + if (needSecurity) { + log.warning("Issue body does not support setting a visibility role - ignoring"); + return; + } + var query = JSON.object() .put("fields", JSON.object() .put("description", body)); @@ -479,7 +491,7 @@ private void addWebLinkAsComment(Link link) { } private void addWebLink(Link link) { - if (jiraProject.jiraHost().visibilityRole().isPresent()) { + if () { addWebLinkAsComment(link); return; }