From c40e621f27de28844fed9fa89c3cf909885a1922 Mon Sep 17 00:00:00 2001 From: Zhao Song Date: Fri, 7 Jun 2024 20:27:49 +0000 Subject: [PATCH] 2290: Update PullRequest::updateReview Reviewed-by: erikj --- .../java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java | 2 +- forge/src/main/java/org/openjdk/skara/forge/PullRequest.java | 2 +- .../java/org/openjdk/skara/forge/github/GitHubPullRequest.java | 2 +- .../java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java | 2 +- test/src/main/java/org/openjdk/skara/test/TestPullRequest.java | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java b/bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java index e4e72388e..d2cbbd7dc 100644 --- a/bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java +++ b/bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryPullRequest.java @@ -68,7 +68,7 @@ public void addReview(Review.Verdict verdict, String body) { } @Override - public void updateReview(int id, String body) { + public void updateReview(String id, String body) { } @Override diff --git a/forge/src/main/java/org/openjdk/skara/forge/PullRequest.java b/forge/src/main/java/org/openjdk/skara/forge/PullRequest.java index 1ca39dd1e..2743ef40b 100644 --- a/forge/src/main/java/org/openjdk/skara/forge/PullRequest.java +++ b/forge/src/main/java/org/openjdk/skara/forge/PullRequest.java @@ -50,7 +50,7 @@ public interface PullRequest extends Issue { /** * Updates the comment body of a review. */ - void updateReview(int id, String body); + void updateReview(String id, String body); /** * Add a file specific comment. diff --git a/forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java b/forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java index 3b95106b7..bd2b1962d 100644 --- a/forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java +++ b/forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java @@ -181,7 +181,7 @@ public void addReview(Review.Verdict verdict, String body) { } @Override - public void updateReview(int id, String body) { + public void updateReview(String id, String body) { request.put("pulls/" + json.get("number").toString() + "/reviews/" + id) .body("body", body) .execute(); diff --git a/forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java b/forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java index 66b42722e..6fef0c790 100644 --- a/forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java +++ b/forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabMergeRequest.java @@ -199,7 +199,7 @@ public void addReview(Review.Verdict verdict, String body) { } @Override - public void updateReview(int id, String body) { + public void updateReview(String id, String body) { throw new RuntimeException("not implemented yet"); } diff --git a/test/src/main/java/org/openjdk/skara/test/TestPullRequest.java b/test/src/main/java/org/openjdk/skara/test/TestPullRequest.java index 522159702..269279e12 100644 --- a/test/src/main/java/org/openjdk/skara/test/TestPullRequest.java +++ b/test/src/main/java/org/openjdk/skara/test/TestPullRequest.java @@ -99,7 +99,7 @@ public void addReview(Review.Verdict verdict, String body) { } @Override - public void updateReview(int id, String body) { + public void updateReview(String id, String body) { throw new RuntimeException("not implemented yet"); }